Skip to content

fix(test): align issue workflow reference assertion#37

Merged
YiWang24 merged 1 commit into
mainfrom
fix/self-test-routing-issue-uses-assertion
May 4, 2026
Merged

fix(test): align issue workflow reference assertion#37
YiWang24 merged 1 commit into
mainfrom
fix/self-test-routing-issue-uses-assertion

Conversation

@YiWang24

@YiWang24 YiWang24 commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Update tests/actions/self-test-routing.bats assertion for issue-ops.yml to match the current reusable workflow reference format.
  • Validate the owner/repo path plus 40-char SHA pin in the uses: value.

Verification

  • bats tests/ --recursive

Artifacts

Co-Authored-By: Oz oz-agent@warp.dev


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Summary by CodeRabbit

  • Tests
    • Updated workflow validation to enforce fully pinned reusable workflow references with commit SHA instead of relative paths, ensuring stricter version control for workflow dependencies.

Update self-test routing assertion to match owner/repo reusable workflow refs pinned by SHA.

Co-Authored-By: Oz <oz-agent@warp.dev>
@qodo-code-review

Copy link
Copy Markdown
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

A test assertion in the issue-routing test suite was updated to require a fully SHA-pinned external reusable-workflow reference (YiAgent/OpenCI/.github/workflows/reusable/issue.yml@<40-hex>) instead of accepting the unpinned local path.

Changes

Test Assertion Update

Layer / File(s) Summary
Test Expectation
tests/actions/self-test-routing.bats
The issue-ops.yml calls reusable issue.yml assertion now requires a fully pinned uses: reference with a 40-character SHA hash instead of a local unpinned path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A hop and a pin, the workflow's been locked,
No more local paths that drift and unblock—
With SHA in tow, the reference runs true,
External and trusted, your CI shines through! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: aligning an issue workflow reference assertion in tests, which matches the changeset's focus on updating the self-test-routing.bats file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/self-test-routing-issue-uses-assertion

Review rate limit: 9/10 reviews remaining, refill in 6 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown

@YiWang24 YiWang24 merged commit d18ad10 into main May 4, 2026
7 of 8 checks passed
@YiWang24 YiWang24 deleted the fix/self-test-routing-issue-uses-assertion branch May 4, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant